Fix: Remove conditional checks on secrets #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrets cannot be accessed in conditional expressions in reusable workflows. Instead, use continue-on-error to allow the GitHub App token step to fail gracefully if APP_ID/APP_PRIVATE_KEY aren't provided. The action will fall back to using GITHUB_TOKEN if the app token isn't available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GitHub Actions doesn't allow accessing secrets in
ifconditionals within reusable workflows (workflow_call).Solution
Removed the
ifcondition from the GitHub App token generation step and addedcontinue-on-error: trueinstead. This allows the step to fail gracefully if APP_ID/APP_PRIVATE_KEY aren't provided, and the Claude action will fall back to using GITHUB_TOKEN.Impact
The workflow will now pass validation and run successfully.